Handle JSON event query responses that contain a nil result field#22
Closed
frozenbubbleboy wants to merge 2 commits intoRubyOpenSource:masterfrom
Closed
Handle JSON event query responses that contain a nil result field#22frozenbubbleboy wants to merge 2 commits intoRubyOpenSource:masterfrom
frozenbubbleboy wants to merge 2 commits intoRubyOpenSource:masterfrom
Conversation
| # Handle the situation where the 'result' key in the JSON response does not | ||
| # point to a hash, but instead is nil. | ||
| # This has been seen in the wild on an installation of Zenoss 4.2.5 | ||
| if(json['result'].nil? |
Author
|
Yeah, sorry about that. I've removed the extra (. |
Member
|
The Travis failures were because we needed to update a couple things. I've done this in #23, can you rebase on to master and try pushing again when you get a chance? |
Member
|
Based on our discussion, it sounds like this isn't absolutely needed. This also might be a breaking change for someone who handles these |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.